SDEV-4155 - switch to source.displayName for Pharmacogenomic filterin… #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g - so same properties can be used to filter pori_ipr_python kbmatches. Replaced PHARMACOGENOMIC_SOURCE_EXCLUDE_LIST with GSC_PHARMACOGENOMIC_SOURCE_DISPLAYNAME_EXCLUDE_LIST.
dustinbleile
requested review from
darenillas,
mathieulemieux,
creisle,
elewis2,
calchoo,
Nithriel and
a team
|
Looks like the updates for black will need to be done first, before these github builds will work. |
elewis2
requested changes
Feb 16, 2024
graphkb/genes.py
Outdated
| ], | ||
| }, | ||
| ignore_cache=False, | ||
| ): | ||
| if record["source"]: # type: ignore | ||
| if record["source"]["name"].lower() in PHARMACOGENOMIC_SOURCE_EXCLUDE_LIST: # type: ignore | ||
| if record["source"]["displayName"] in GSC_PHARMACOGENOMIC_SOURCE_DISPLAYNAME_EXCLUDE_LIST: # type: ignore |
There was a problem hiding this comment.
can we make the exclude list passable as a parameter?
There was a problem hiding this comment.
Sure, done.
But let's not worry too much about this, given Yaoqin's statements on the ticket, about using other methods to select.
…RCE_DISPLAYNAME_EXCLUDE_LIST.
mathieulemieux
approved these changes
Feb 22, 2024
elewis2
approved these changes
Feb 29, 2024
Nithriel
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…g - so same properties can be used to filter pori_ipr_python kbmatches. Replaced PHARMACOGENOMIC_SOURCE_EXCLUDE_LIST with GSC_PHARMACOGENOMIC_SOURCE_DISPLAYNAME_EXCLUDE_LIST.